Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use hostname instead of IP in URL #199

Closed
nebuchad908 opened this issue Jun 22, 2020 · 4 comments · Fixed by #246
Closed

Use hostname instead of IP in URL #199

nebuchad908 opened this issue Jun 22, 2020 · 4 comments · Fixed by #246
Labels
bug enhancement

Comments

@nebuchad908
Copy link

Hello.

If subnets array "allowedSubnets" contains any subnets, then URL

http://a.d.d.r:2222/ssh/host/host.name?port=1234 not working with error 401 UNAUTHORIZED

when I change host.name to their IP, session works fine.
@billchurch
Copy link
Owner

Good point, there's definitely no rectification between hostname and the allowedSubnets feature. Will add this to the list of bug/enhancements for the next release.

@nebuchad908
Copy link
Author

Nice. I think it's easy to resolve IP of requested hostname and use it. Thanks!

@billchurch
Copy link
Owner

Yeah, should be easy to solve no doubt...

@zwiy zwiy mentioned this issue May 1, 2021
Closed
@billchurch
Copy link
Owner

fixed in #234

@billchurch billchurch mentioned this issue May 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

0.4.0 Release billchurch/webssh2
2 participants
@billchurch @nebuchad908