Enqueue global.js

[jaredatch]

Not sure about yall, but on almost every site I do I have at least 1 js file that needs to be enqueued, usually globally.

Should we set something for default as a reference.

This is what I had in my old base theme:

/**
 * Global enqueues
 *
 * @since 1.0.0
 */
function ja_global_enqueues() {
    global $wp_styles;

    // javascript
    wp_enqueue_script( 'global', CHILD_URL . '/lib/js/global.js', array( 'jquery' ), CHILD_THEME_VERSION, false );

    // css
    wp_enqueue_style( 'ie', CHILD_URL . '/lib/css/ie.css' );
    $wp_styles->add_data( 'ie', 'conditional', 'lt IE 9'  );
}
add_action( 'wp_enqueue_scripts', 'ja_global_enqueues' );

[billerickson]

Looks good to me. I've never seen that global $wp_styles used for conditionals, neat!

I'd use get_stylesheet_directory() instead of CHILD_URL. WP core recommends using functions rather than globals, and are deprecating them in core I think (couldn't find the ticket). I know these are Genesis global variables, but it's good practice to not use them.

It's a good idea to prefix the javascript and stylesheet slug (ea-global rather than global).

I'd leave the Javascript there, also creating a file in /inc/js/global.js. But I'd have the stylesheet part commented out.

[GaryJones]

I've never seen that global $wp_styles used for conditionals, neat!

http://code.garyjones.co.uk/enqueued-style-sheet-extras

I'd like to see the enqueueing of CSS and JS split into two different functions.