Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix small typo add requirements.txt #9

Merged
merged 2 commits into from Jan 19, 2022

Conversation

jgraham909
Copy link
Contributor

Thanks for sharing, I've been meaning to look at beautiful soup for a while.

Looks like there is a typo on line 50 of collect_texts.py

Added requirements.txt to capture dependencies to easily install via pip install -r requirements.txt especially convenient if using conda environments to avoid cluttering main python env.

This also required liblept5 and firefox-geckodriver installed via apt on ubuntu before anything would run. Maybe I'll try to document the full set via a Dockerfile as I'm sure there are other dependencies I already had installed.

There appear to be other issues I'm struggling through, not sure if user error, documentation, or something other. I'll try to grok things a bit better so I can articulate the other issues and either create issues or PRs.

@billfitzgerald
Copy link
Owner

These are both great additions.

And yeah, the documentation definitely needs improvement.

Also: Huge +1 for a Dockerfile - that would be amazing.

@billfitzgerald billfitzgerald merged commit 6417627 into billfitzgerald:main Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants