Recreate awesome books app with es6 imports #1
Conversation
There was a problem hiding this comment.
Hi Team,
Good job so far!
To Highlight! 👏 🟢
✔️ Good commit messages
✔️ Descriptive Readme file
✔️ Your project is running as expected.
There are some issues that you still need to work on to get this project approved, but you are almost there!
Status: Requires Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
index.css
Outdated
| } | ||
|
|
||
| .book-title { | ||
| /* text-transform: uppercase; */ |
There was a problem hiding this comment.
- Please kindly remove commented code from your code base, as it makes your code dirty and less readable.
modules/UserInterface.js
Outdated
| import Book from './Book.js'; | ||
| import * as luxon from './Date.js'; | ||
|
|
||
| // import * as luxon from '../node_modules/luxon/src/luxon.js'; |
There was a problem hiding this comment.
- Please kindly remove commented code from your code base, as it makes your code dirty and less readable.
There was a problem hiding this comment.
Hi Billions,
Your project is complete! There is nothing else to say other than... it's time to merge it 🚀 :
Congratulations! 🎉
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
There was a problem hiding this comment.
Hi @Team,
While you made a great effort in this project, unfortunately, I cannot proceed to review your code.
Invalid Code Review Request
You have submitted a project, that has already been approved by the previous code reviewer.
Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
Invalid Code Review Request does not count into the code reviews limit.
|
As in this project description, the information about working on all repos in the group was missing, we need to approve this PR as submitted individually by all students in your group. Please request a review from your dashboard once again, so the next reviewer can see your request and approve it. |
There was a problem hiding this comment.
Approved 👏
Hi there,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
To Highlight:
- The Pull Request has a proper title and description. ✔️
- You have added a descriptive Readme file. Good Job. ✔️
- There is no linter error is present. ✔️
- Project has met all the technical aspects you needed for this project. Keep rocking! ✔️
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
As described in the Code reviews limits policy you have a limited number of code reviews per project which you can see from your dashboard. If you think that the code review was not fair, you can request a second opinion using this form
This PR recreates the awesome books project using es6