Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discount Coupons are applied to all items rather than listed separately resulting in confusing invoices. #10

Closed
OskarOstlund opened this issue Jul 15, 2020 · 6 comments

Comments

@OskarOstlund
Copy link

image

Would you buy an item with a discount invoice as the example seen above, instead of including the discount as a separate item with a negative cost are the discount taken from the separate cost of the items, as can be seen in the picture below.
image

This could result in rather confusing invoices for the customers.

@MichaelBengtsson
Copy link
Collaborator

This is how WooCommerce works as standard. A coupon is applied to all the products in the cart. If you want a discount to show up as its own discounted line, then you need to add it as a negative fee. But this is not the standard in WooCommerce

@stefanliden
Copy link

the discount code is not visible regardless of the type of discount code in the payment call to Billmate. This means that customers will never be able to see on their invoices that a discount code has been used. Example if a product has received a discount of 10%, it should be sent as this

$ values ["Articles"] [1] = array (
"artnr" => "B456",
"title" => "Article 2",
"quantity" => "3.5",
"aprice" => "56780",
"taxrate" => "25",
"discount" => "10",
"withouttax" => "178857",
);

If this is not included, customers will call and shop and ask us why they can not see the discount code on their receipts / invoices.We must also be sure that it is possible to give a discount for items even if they have different VAT rates such as 6% 25%

@NiklasHogefjord
Copy link
Collaborator

@stefanliden How should we add a discount in the request to Billmate if it is a fixed cart amount discount?

The API-docs mention that it should be sent in as %, but fixed amount coupons can also be created in WooCommerce.

@NiklasHogefjord
Copy link
Collaborator

@MattiasNilsson Would it be ok to just add the discount on each order line for display/information? Not be a part of the totals calculation? I have tested and it seem to work ok like that.

NiklasHogefjord added a commit that referenced this issue Nov 1, 2020
@NiklasHogefjord
Copy link
Collaborator

@OskarOstlund perhaps you can test this and see that it looks ok for you as well?

@OskarOstlund
Copy link
Author

Tested and approved.

Discounts have now been included in the

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants