Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: rank is always unranked #75

Open
2 of 3 tasks
Jackywathy opened this issue Jan 8, 2021 · 1 comment · May be fixed by #76
Open
2 of 3 tasks

BUG: rank is always unranked #75

Jackywathy opened this issue Jan 8, 2021 · 1 comment · May be fixed by #76

Comments

@Jackywathy
Copy link
Contributor

Jackywathy commented Jan 8, 2021

the get_rank based on rank_id is incomplete. It currently returns UNRANKED. We should try to fix this up before release. Unfortunately missed this before sending the earlier pull request.

need to somehow differentiate between old style vs new style ranks (since ubi changed the rank system). This is currently done by hard coding each season's ranks in season.py (possible enhancement in the future could be to consolidate this into just two).

  • implement get_rank(rank_id) to return the rank corresponding to that rank id
  • add rank definitions for earlier seasons
  • ensure rank works for each season (commit this as a example file so we can test this in the future)
@Jackywathy
Copy link
Contributor Author

@billy-yoyo probably best not to release till this is fixed - should be pretty simple though.

@Jackywathy Jackywathy linked a pull request Jan 9, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant