-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfile: xgo compile for darwin architecture fails #47
Comments
The xgo builds for macOS, Linux and Windows are used for testing - the actual builds are built on the correct platform. Since the darwin build has stopped working, this can be an excuse for removing these builds as they really are only for testing. The Android and IOS builds will continue to be built by xgo See: winfsp/cgofuse#47
I've decided to drop this build from rclone for the moment as it is only used for testing, so no urgency! |
Hey, Nick. Sorry for the delay in responding. I will have a look at this tomorrow. |
I believe the right thing here is to update the headers used in the Docker image. I note that OSXFUSE 3.x series still uses the FUSE2 API, so it should be ok to update to latest OSXFUSE. |
So the docker image has now been modified to include OSXFUSE 3.8.3 which includes the Unfortunately this is now failing during
Is there a way to trigger DockerHub builds without the build cache? I no longer have easy access to Docker for Linux containers and I may not be able to fix this timely. |
I can confirm that that fixes the rclone builds - thanks Bill :-) Sorry you had to debug on DockerHub - that is a miserable experience. |
Excellent. I am closing this and will follow up on any additional work via rclone/rclone#4393. |
The xgo builds for macOS, Linux and Windows are used for testing - the actual builds are built on the correct platform. Since the darwin build has stopped working, this can be an excuse for removing these builds as they really are only for testing. The Android and IOS builds will continue to be built by xgo See: winfsp/cgofuse#47
When I try an xgo compile
I get this error
I bisected the problem and (unsuprisingly!) this was the commit that broke it 8e41a0c - this was new to v1.3.0
So I think the FUSE headers need to be updated somehow in the Docker file for darwin.
https://github.com/billziss-gh/cgofuse/blob/f414e61c21ae71e205e28156b55093867fb9b458/Dockerfile#L14-L24
I note that 2.8.3 is a way behind the current 3.10.6
So I think either we need to do one of these
#ifdef
out that feature on osxI'm not sure which of those is the best way forward though!
The text was updated successfully, but these errors were encountered: