Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

features with no ID attribute but with Parent attributes #10

Closed
billzt opened this issue Jun 28, 2017 · 0 comments
Closed

features with no ID attribute but with Parent attributes #10

billzt opened this issue Jun 28, 2017 · 0 comments

Comments

@billzt
Copy link
Owner

billzt commented Jun 28, 2017

the script assumes, incorrectly, that all items with a Parent have an ID, which is not required (unless they themselves have children), and such subfeatures would not be placed by the script

push@{$parent2children{$parent} }, $id #when $id is void?

Thanks to Miklos Csuros’ review
In fact, the current code is able to deal with this.

if (defined($id)) {
     $id2line{$id} = $line;
}
else {
     $id2line{$line} = $line;
}

Considering to add some comments here.

@billzt billzt closed this as completed in 4d4f4e3 Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant