[Improvement] Avoid errors in the log for cars that are not supported

[gerard33]

@m1n3rva
Would be good to have another look at the "lscType": "NOT_SUPPORTED" solution we have discussed earlier here and here.

As is shown here the HA log is showing a lot of errors when the car has no relevant data to show.

We should be able to avoid that and show a neat message in the log stating that it is an unsupported car.

[m1n3rva]

@gerard33 I'm already checking the lscType in Vehicle.available_attributes. This function will give you all the attributes that are available for this vehicle. So if you use only show attributes listed there, you should be safe.

What would you like the API to look like? What should the library do when "lscType": "NOT_SUPPORTED"?

[gerard33]

The relevant HA code for the binary sensors as an example is as follows.

So I don't check if the attributes are available in Vehicle.available_attributes. The same approach goes for the sensors in HA as shown here.

But to my understanding these checks should be enough. Because if the car is not supported then only the available sensors should be added.

But in #95 the logs shows a.o. the following error:

 File "/srv/homeassistant/lib/python3.5/site-packages/homeassistant/components/binary_sensor/bmw_connected_drive.py", line 117, in device_state_attributes
    result['lights_parking'] = vehicle_state.parking_lights.value
AttributeError: 'NoneType' object has no attribute 'value'

I would not suspect the parking_lights binary sensor to be added due to the current checks.
What's your opinion on this?

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.