Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model & BCF viewpoint business logic #3

Closed
barnabasmolnar opened this issue Jun 14, 2019 · 2 comments
Closed

Model & BCF viewpoint business logic #3

barnabasmolnar opened this issue Jun 14, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@barnabasmolnar
Copy link
Contributor

barnabasmolnar commented Jun 14, 2019

Models can already be dynamically added and removed. Corresponding BCF viewpoints however don't yet respond to props changing. It might be worth refactoring the model and viewpoint loading logic in such a way that the two are more coupled. So instead of having a separate models and bcfViewpoints prop, we could instead have one which includes both a model and its corresponding BCF viewpoint. Thus when changing models, updating the respective viewpoints as well could be a whole lot easier conceptually and implementation wise too.

After a boatload of trial & error and some investigation, I have found that BCF viewpoints are more tied to the scene object itself rather than the models on the scene. They seem to be only connected to models in that a selection array of objects can be supplied to select entities on models.

As a result, I propose that instead of a bcfViewpoints prop that accepts an array of viewpoints, a bcfViewpoint (singular) prop be implemented that accepts one viewpoints obejct.

@barnabasmolnar barnabasmolnar added the enhancement New feature or request label Jun 14, 2019
@barnabasmolnar barnabasmolnar self-assigned this Jun 14, 2019
@barnabasmolnar barnabasmolnar changed the title Model & BCF viewpoint changing Model & BCF viewpoint business logic Jun 16, 2019
@barnabasmolnar
Copy link
Contributor Author

Changes implemented in: 82489d4

@barnabasmolnar
Copy link
Contributor Author

Update documentation/readme accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant