[R4R] the miner module should propose block on a proper fork #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
approved these changes
Aug 9, 2021
kyrie-yl
reviewed
Aug 9, 2021
| for seen, recent := range snap.Recents { | ||
| if recent == p.val { | ||
| // Signer is among recents, only wait if the current block doesn't shift it out | ||
| if limit := uint64(len(snap.Validators)/2 + 1); number < limit || seen > number-limit { |
There was a problem hiding this comment.
please put the "limit := " expression before the if expression, it can make the 'if' expression more concise.
There was a problem hiding this comment.
if {statement}; {condition} is a widely used grammar, I think it is concise enough for reviewers.
kyrie-yl
approved these changes
Aug 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add a description of your changes here...
Rationale
When there are multi forks of the same height, the miner module may give up the correct fork in the current implementation.
Example
For validator, the forks who has the same TD but:
get more chance to be included in the canonical chain.
Changes
The recent sign validator will not try to propose a block anymore.
Preflight checks
make build)make test)Already reviewed by
...
Related issues
... reference related issue #'s here ...