[R4R]use fixed gas price when network is idle #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
changed the title
abelliumnt
previously approved these changes
Nov 16, 2020
yutianwu
previously approved these changes
Nov 16, 2020
unclezoro
force-pushed
the
fixedGas
branch
3 times, most recently
from
7371524
to
e0685dc
Compare
abelliumnt
reviewed
Nov 17, 2020
eth/gasprice/gasprice.go
Outdated
| @@ -103,6 +109,7 @@ func (gpo *Oracle) SuggestPrice(ctx context.Context) (*big.Int, error) { | |||
| sent := 0 | |||
| exp := 0 | |||
| var blockPrices []*big.Int | |||
| var totalSamples int | |||
There was a problem hiding this comment.
totalSamples -> totalTxSamples
sampleThreshold -> sampleTxsThreshold
abelliumnt
approved these changes
Nov 17, 2020
yutianwu
approved these changes
Nov 17, 2020
3 tasks
Pythonberg1997
pushed a commit
to Pythonberg1997/bsc
that referenced
this pull request
Sep 1, 2022
[R4R] Release For BSC v1.1.11
NashBC
pushed a commit
to NashBC/bsc
that referenced
this pull request
Sep 28, 2022
Fix some audit comments
zzzckck
pushed a commit
that referenced
this pull request
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The defect of the previous implementation of gas-price oracle:
When the network is idle, one high gas price transaction may affect the result because of the lack of other transaction, and eventually cause others use high gas-pricce.
Improvement:
Once the number of txs in the last 20 blocks exceeds a threshold, we consider the network is busy.
Changes
Notable changes:
A new configure:
GPO.OracleThreshold, default value is 0. It is a value we used to decide the network is busy or not.Preflight checks
make build)make test)Related issues