Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci/fix test flow #473

Merged
merged 5 commits into from Nov 1, 2021
Merged

Ci/fix test flow #473

merged 5 commits into from Nov 1, 2021

Conversation

j75689
Copy link
Contributor

@j75689 j75689 commented Oct 20, 2021 •
edited

Description

  1. Fix wrong error message on build Dockerfile.truffle.
    image
  2. Remove unnecessary job in unit test.
  3. Fix unit test error.

Rationale

N/A

Example

N/A

Changes

Notable changes:

  • .github/workflows/integration-test.yml
  • .github/workflows/unit-test.yml
  • common/prque/sstack.go

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • manual transaction test passed

Already reviewed by

N/A

Related issues

N/A

@j75689 j75689 force-pushed the ci/fix_test_flow branch 4 times, most recently from 8ddd7ae to 509b9f6 Compare October 21, 2021 06:26
@j75689 j75689 force-pushed the ci/fix_test_flow branch 2 times, most recently from 450a988 to e293811 Compare October 21, 2021 07:16
@yutianwu yutianwu merged commit 98c4e81 into bnb-chain:develop Nov 1, 2021
This was referenced Nov 2, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yutianwu yutianwu yutianwu approved these changes

@unclezoro unclezoro unclezoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@j75689 @yutianwu @unclezoro