[R4R]les: fix GetProofsV2 bug (#21896) #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
changed the title
yutianwu
approved these changes
Jan 8, 2021
abelliumnt
approved these changes
Jan 8, 2021
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in GetProofsV2 request serving that could potentially cause a panic because of header being nil.
Rationale
A DoS vulnerability can make a LES server crash via malicious GetProofsV2 request from a connected LES client.
Example
Mirror PR: ethereum/go-ethereum#21896
advisories: GHSA-r33q-22hv-j29q
Changes
This vulnerability only concerns users explicitly enabling les server; disabling les prevents the exploit.
Preflight checks
make build)make test)Already reviewed by
...
Related issues
... reference related issue #'s here ...