[R4R] BEP39 - add memo to transfer kafka message #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ackratos
requested review from
darren-liu,
yutianwu,
unclezoro and
rickyyangz
and removed request for
darren-liu,
yutianwu and
rickyyangz
unclezoro
approved these changes
Aug 5, 2019
rickyyangz
requested changes
Aug 7, 2019
app/pub/helpers.go
Outdated
| msgs := t.GetMsgs() | ||
| for _, m := range msgs { | ||
| msg, ok := m.(bank.MsgSend) | ||
| if !ok { | ||
| continue | ||
| } | ||
| var memo string | ||
| if stdTx, ok := t.(auth.StdTx); ok { |
There was a problem hiding this comment.
memo is in the tx level, you can get the memo outside the for loop. Also, you can merge the two force conversion into one
t := value.(sdk.Tx) and stdTx, ok := t.(auth.StdTx)
rickyyangz
approved these changes
Aug 12, 2019
This was referenced Aug 12, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add memo to transfer kafka message
Document:
https://github.com/binance-chain/docs-site/pull/151
Websocket:
https://github.com/binance-chain/websocket-ap/pull/101
Rationale
BEP39
Example
{ "stream":"transfers", "data":{ "e":"outboundTransferInfo", "E":1122, "H":"3251F90C832B17E5C58F8A06B9BA6757AA168E5BF2CEE5A10EB5AE6313EF9655", "M":"1234", "f":"bnb15ev5gmsvmwsd93zm837d277u8lr7avdcfe5ntc", "t":[ { "o":"bnb12lu3cs95afx3x222uyr58kfx3mq3wdw2h0t8gx", "c":[ { "a":"BNB", "A":"0.01000000" } ] } ] } }Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
... reference related issue #'s here ...