[R4R] Add max lock time in time lock plugin #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
requested review from
ackratos,
darren-liu,
abelliumnt,
unclezoro and
rickyyangz
rickyyangz
reviewed
Aug 5, 2019
| @@ -54,6 +55,10 @@ func (msg TimeLockMsg) ValidateBasic() sdk.Error { | |||
| return ErrInvalidLockTime(DefaultCodespace, fmt.Sprintf("lock time(%d) should be larger than 0", msg.LockTime)) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
no, we do not, for there is no such txs included in block
rickyyangz
approved these changes
Aug 5, 2019
abelliumnt
reviewed
Aug 5, 2019
plugins/tokens/timelock/msgs.go
Outdated
| @@ -54,6 +55,10 @@ func (msg TimeLockMsg) ValidateBasic() sdk.Error { | |||
| return ErrInvalidLockTime(DefaultCodespace, fmt.Sprintf("lock time(%d) should be larger than 0", msg.LockTime)) | |||
| } | |||
|
|
|||
| if msg.LockTime >= MaxLockTime { | |||
| return ErrInvalidLockTime(DefaultCodespace, fmt.Sprintf("lock time(%d) should not be less than %d", msg.LockTime, MaxLockTime)) | |||
There was a problem hiding this comment.
fmt.Sprintf("lock time(%d) should be less than %d", msg.LockTime, MaxLockTime)
abelliumnt
reviewed
Aug 5, 2019
| MinLockTime = 60 * time.Second | ||
| MaxDescriptionLength = 128 | ||
| MinLockTime = 60 * time.Second | ||
| MaxLockTime int64 = 253402300800 //seconds of 10000-01-01, which is required by amino |
abelliumnt
approved these changes
Aug 5, 2019
darren-liu
approved these changes
Aug 5, 2019
This was referenced Aug 12, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix: #640
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
... reference related issue #'s here ...