Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket connection exceptions are not handled by the user neither the on_error callback is called #173

Open
malvanos opened this issue Feb 19, 2024 · 1 comment

Comments

@malvanos
Copy link

malvanos commented Feb 19, 2024

Websocket connection exceptions are not handled by the user neither the on_error callback is called. It seems that there is a pull request for that #158. However, I believe the pull request for the Spot is better: binance/binance-connector-python#274 compared with #158.

Expected behaviour
Websocket connection errors should be handled by the on_error callback.

Actual behaviour
The exception is raised inside the thread managing the websocket connection.

Steps to reproduce
When closing the connection with any tool it will make the read to throw an exception.

@Drake1804
Copy link

Got the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants