Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have trouble running the mnist example #97

Closed
Nuullll opened this issue Jul 16, 2018 · 4 comments
Closed

Have trouble running the mnist example #97

Nuullll opened this issue Jul 16, 2018 · 4 comments

Comments

@Nuullll
Copy link

Nuullll commented Jul 16, 2018

File "examples/mnist/eth_mnist.py", line 159,
Function get_ngram_counts is not defined.
@djsaunde
Copy link
Collaborator

Hi @Nuullll,

We just updated the master branch to fix this.

@Nuullll
Copy link
Author

Nuullll commented Jul 17, 2018

I don't think the bug has been fixed :)

@djsaunde
Copy link
Collaborator

@hqkhan It looks like get_ngram_counts should be replaced with update_ngram_scores? Could you fix this?

image

@djsaunde djsaunde reopened this Jul 17, 2018
@hqkhan
Copy link

hqkhan commented Jul 17, 2018

Hi @Nuullll, I just updated master with the correct implementation. The code that produced the error should not have been there. I tested eth_mnist.py and it works on my end now.

Please let me know if you're still having issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@djsaunde @Nuullll @hqkhan