Skip to content

Latest commit

 

History

History
23 lines (17 loc) · 1.27 KB

PULL_REQUEST_TEMPLATE.md

File metadata and controls

23 lines (17 loc) · 1.27 KB
Raw

CHECKLIST

We will not consider a PR untill all of the following items are checked off--thank you!

  • There aren't existing pull requests attempting to address the issue mentioned here
  • Submission developed in a feature branch--not master
  • Confirmed there are no outstanding npm run eslint issues
  • Added/updated tests for new/changed code
    • TIP: You can watch/run a specific test during developemnt with npm run test:watchone test/TEST-FILE-NAME
  • Appropriate coverage validated with npm run cover:local
  • All npm test passes without any issues

CONVINCING DESCRIPTION

RELATED INFORMATION

BE WARNED

  • If any of the checklist items are missed, incomplete or invalid we will not accept the PR
  • If you are not responsive to feedback on your PR we will not accept the PR
  • If we do not accept your PR we will provide feedback on the PR indicating why
  • After some time, we will close PRs that have not been accepted

When we decline or close your PR. You are encouraged to address the concernes outlined in the PR and then re-submit it. We want contributions. We also need for them to be of high quality and high value and to not take undue resources away from the features and enhancements the core team is working on. Thanks for understanding!