patchperl sets executable bit on hints file which causes t/porting/exec-bit.t to fail

[rwstauner]

Running patchperl on the perl-5.14.0 RC's
causes t/porting/exec-bit.t to fail.

The hints/linux.sh file does not have the exec bit set in the tar,
but patchperl sets it when overwriting
(even though the hints file in Devel::PatchPerl::Hints is the same as the one in the tar).

$ tar -tvjf ~/perl5/perlbrew/dists/perl-5.14.0-RC3.tar.bz2 perl-5.14.0-RC3/hints/linux.sh 
-r--r--r-- jesse/jesse   15072 2011-05-07 20:10 perl-5.14.0-RC3/hints/linux.sh

Since the hints files aren't listed in Porting/exec-bit.txt
t/porting/exec-bit.t throws this error:

# Failed at porting/exec-bit.t line 42
# Remove the exec bit or add '../hints/linux.sh' to Porting/exec-bit.txt
porting/exec-bit.t ................................................
Failed 1/55 subtests

See also http://perl5.git.perl.org/perl.git/commit/ff906f87ce1519416ddfff76ae8e1d8fa42ed082

I don't know enough about what happens with this hints file to submit a patch.
When Is the hints shell script executed? Is there a later time where patchperl can unset the bit?
Or should the hints files keep their exec bits in perl.git ?

I should add that I have not used patchperl before and don't know anything about it,
but @gugod's latest perlbrew uses a Fatpacked version of patchperl before building the perl source.
From what I can tell a bug in previous versions of perlbrew failed to execute patchperl which
is why I've succeeded up until this point.

Is it a bug in perlbrew that patchperl is being used?
Or is this executable bit mismatch a bug in patchperl?

[rwstauner]

sorry about updating the original issue comment...
i neglected to use code blocks and ended up with heading tags.

[bingos]

Hi,

Thanks for catching this, fixed with commit 9adaa25

And released to CPAN as version 0.36