Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer-to-peer code review: Sam, Recillah, Aziz and Hussen #7

Closed
samlorlah opened this issue Aug 18, 2022 · 1 comment
Closed

Peer-to-peer code review: Sam, Recillah, Aziz and Hussen #7

samlorlah opened this issue Aug 18, 2022 · 1 comment

Comments

@samlorlah
Copy link

Good Job !!!

Your project is great.
✔️ Good UI
✔️ Responsive
✔️ Clean / Organized code

However , you might need to work on the issue(s) below:

  • The index for your task should follow the project requirement - By default new tasks should have the property completed set to false and the property index set to the value of the new array length (i.e. if you're adding a 5th task to the list, the index of that task should equal to 5).
@binhussen
Copy link
Owner

binhussen commented Aug 18, 2022

Thank you @Rn486, @AzizRAA and @samlorlah for your feedback, I have updated the changes as requested and made the fixes we discussed Link here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants