Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User control of ignored changes #69

Closed
mgree opened this issue Jun 26, 2023 · 0 comments · Fixed by #91
Closed

User control of ignored changes #69

mgree opened this issue Jun 26, 2023 · 0 comments · Fixed by #91
Assignees
@angelhof
Labels
enhancement New feature or request
Milestone
try 0.2

Comments

@mgree
Copy link
Contributor

mgree commented Jun 26, 2023

Right now ignore_changes is using logic that's only appropriate for the hs stuff. We should (a) have nothing be ignored by default and (b) let the user specify what to ignore.

I imagine:

$ try -i '*~' -i '#*#' -- emacs -nw foo.txt
...

We should allow multiple instances of the -i flag, with the expectation that these will be passed as patterns to grep -v.

Somewhat related to #25.
@mgree mgree added the enhancement New feature or request label Jun 26, 2023
@angelhof angelhof added this to the try 0.2 milestone Jun 28, 2023
@angelhof angelhof self-assigned this Jun 29, 2023
@angelhof angelhof linked a pull request Jun 29, 2023 that will close this issue
Allow try to have a custom list of ignored paths #91
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelhof angelhof

Labels
enhancement New feature or request
Projects
None yet
Milestone
try 0.2
Development

Successfully merging a pull request may close this issue.

Allow try to have a custom list of ignored paths binpash/try
2 participants
@mgree @angelhof