Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making changes while waiting for Sync-All drops commits #327

Open
mahaloz opened this issue Aug 13, 2023 · 0 comments
Open

Making changes while waiting for Sync-All drops commits #327

mahaloz opened this issue Aug 13, 2023 · 0 comments
Labels
binary ninja bug Something isn't working

Comments

@mahaloz
Copy link
Member

mahaloz commented Aug 13, 2023

Description

If you start a sync all then make changes while it is running, your changes can very likely get dropped.

This is likely a deeper issue of passing state to push_artifact, which causes a stale state to be present while the user is making changes.

This is mostly an issue in NOT IDA, since sync-all and magic-sync usually locks the decompiler while it works. One possible solution is to just lock the entire decompiler on purpose while this runs with a sick progress bar.

Found by @saagarjha.

Steps to reproduce the bug

  1. Sync-all from a user
  2. Make a change while running
  3. See in the BS state that only the sync-all changes made it

Environment

No response

Additional context

No response

@mahaloz mahaloz added bug Something isn't working binary ninja labels Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binary ninja bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant