Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partial publications when subproject's bintrayUpload fails #340

Open
mockitoguy opened this issue Feb 3, 2021 · 0 comments
Open

Partial publications when subproject's bintrayUpload fails #340

mockitoguy opened this issue Feb 3, 2021 · 0 comments

Comments

@mockitoguy
Copy link

When subproject's bintrayUpload fails we're getting a partial publication on Bintray. Artifacts uploaded by subprojects with successful bintrayUpload land in Bintray. It's a significant gap, especially when the plugin publishes a partial release to Maven Central and the users are exposed to a bad release (example bad release in Maven Central caused by this bug: mockito/mockito-scala#351)

Tech note (based on my quick look): I believe this is caused by using bintrayUpload.finalizedBy(bintrayPublish). This does not work well because if bintrayUpload fails, the finalizer task still runs (it's by Gradle's finalizer task design). bintrayPublish must not publish when any of the bintrayUpload tasks fail.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant