Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SecurityDefinitions missing "Index" and "IxValue" type family instances #76

Open
arjunkathuria opened this issue Jan 9, 2023 · 0 comments

Comments

@arjunkathuria
Copy link

Hi,

The SecurityDefinitions type defined in the OpenAPI library here

Which is a newtype wrapper over Definitions, which in-turn is a type synonym for an InsOrdHashMap Text type.

SecurityDefinitions seems to be missing type-family instances for Index and IxValue type-families, which enables us to use them with Lenses and refer to their indices using at or ix and set a particular SecurityScheme at that index if needed.

The following instances are already present in the Swagger version of the same data-type here.

Maybe we missed them here. I'll make a PR soon for this.

(Note: They would also need type-class instances for At and Ixed, i'll open a separate issue for that.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant