Fix showing metadata header problems #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a patch to current messages? Basically, a loop over the redis messages so they can be displayed. Thanks. |
|
Not sure what you are asking, could you clarify? The system messages display fine: However, with or without a system message the error messages are showing up above the nav bar, which shouldn't happen. This is also happening on the main deploy currently. I'll try and figure out why this is happening and fix it. |
|
Sorry for the poor wording. What I was asking is to add a fix for the current messages in the system, not only the new ones. However, I think this line does this, is that right? |
|
Yes, that is correct. It url encodes any message as it comes out of the system, so it will work with current as well as future messages. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1745 by escaping the text to be shown in the prep and sample metadata messages before sending into the javascript, then unescaping it before being shown. This removes all characters that could interfere with the javascript working.
See the broken /slash and broken \slash columns above that would otherwise break the system.
