Add artifact creation test handler #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you pull from master? |
…nto add-artifact-creation-test-handler
|
Done! |
|
Looks good. Do you think it's worth adding a test for when the artifact can't be created? |
|
Good call! There was a bug in oauth which prevented to send a useful error to the consumer. That may be why we were sometimes not seeing the error messages on the plugin. |
|
|
||
| Parameters | ||
| ---------- | ||
| filepahts : str |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1878 so review/merge that one first
This adds a new endpoint for the apitest restAPI in which plugin developers can create new artifacts