Plugin installation endpoints

[josenavas]

This adds the needed endpoints so plugins can register themselves using the REST api.

@antgonza there are 2 missing things in here:

• In the class CommandListHandler, perform the call to create, passing parameters using the correct format
• Add a new function in the class qiita_db.software.Command called add_default_parameter_sets that adds new parameter sets to the command. Then you can call this function in the previous handler once the command is created. Actually not needed, there is the DefaultParameters.create call

[antgonza]

Looks good, just one comment and you need to fix the flake8 errors.

[antgonza]

It seems like all 500 errors are missing tests. Could you double check?

[josenavas]

I'm unsure on how to force those errors to happen. I put those as a security guard in case that something unexpected happens (that's why they catch any exception). Other endpoints are similar to this.
Any idea on how to force the error?

[antgonza]

If it's not possible to generate them, why test them?

Now, this is working on from_name_and_version, which only raises QiitaDBUnknownIDError, so the second except is working on:

            sql = """SELECT software_id
                     FROM qiita.software
                     WHERE name = %s AND version = %s"""
            qdb.sql_connection.TRN.add(sql, [name, version])
            res = qdb.sql_connection.TRN.execute_fetchindex()

which will only fail if the DB fails or the structure changes, right? If that's correct I think we can remove them, right?

[josenavas]

If the DB fails, what will be then returned to the client?

[antgonza]

If the DB fails, the Qiita server will fail, right? So no return at all ...

[josenavas]

Not necessarily - our fault tolerant system allows the webserver to still be alive even when the DB is dead.

[antgonza]

K

[coveralls]

Changes Unknown when pulling de87d41 on josenavas:plugin-installation-endpoints into * on biocore:plugin-installation*.