Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_studies #2052

Merged
merged 2 commits into from
Jan 23, 2017
Merged

fix get_studies #2052

merged 2 commits into from
Jan 23, 2017

Conversation

antgonza
Copy link
Member

No description provided.

@antgonza antgonza changed the title WIP: fix get_studies fix get_studies Jan 20, 2017
@antgonza
Copy link
Member Author

Assuming the test pass, which they should (?). This fixes why some studies are not being shown.

  • Old version
    screen shot 2017-01-19 at 6 23 44 pm

  • New version in test environment. Note that this is faster as the UNION is only returning unique values
    screen shot 2017-01-19 at 6 23 51 pm

@ackermag
Copy link

That looks a lot better... Is there any way you can check that there are no samples from North Korea (we have had problems before where N America samples are assigned to N Korea due to incorrect co-ordinates (+/-))?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.503% when pulling b33983b on antgonza:fix-get_studies into 599bcde on biocore:master.

@antgonza
Copy link
Member Author

None.
screen shot 2017-01-19 at 7 03 44 pm

@antgonza
Copy link
Member Author

BTW we can wait for the key to die so the system updates or we can delete any of the stats keys:

  • To find: KEYS *:stats:*
  • To delete: DEL *:stats:*

@josenavas josenavas merged commit c174693 into qiita-spots:master Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants