Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Redbiom to master #2131

Closed
wants to merge 45 commits into from
Closed

Adding Redbiom to master #2131

wants to merge 45 commits into from

Conversation

antgonza
Copy link
Member

@antgonza antgonza commented May 12, 2017

This is the PR agains master to add redbiom, below the ToDo list for completeness.

  • Move out database code from qiita_pet.handler
  • Decide what to do with the context limitation to search based on sequences. Let's discuss this on our next Qiita meeting. R: We will search over all the contexts. Solved Let's get redbiom-ing #2118
  • Decide what to do with displaying on which categories/artifacts the search query is found. Also, let's discuss on next Qiita meeting. R: group by artifact processing, fix in Redbiom improving listing #2132
  • Fix GUI based on decisions on the last points. R: fix in Redbiom improving listing #2132
  • Fix the instuctions
  • request by: @adswafford: user searches for category pH, then the "values" column next to it expands to show the number of samples and values, e.g. 6.0 10, 6.5 23 ...
  • request by: @josenavas: figure out why a number is not a stem - redbiom, this should be addressed in the instructions
  • request by @antgonza: when searching by observation we are not 100% sure if that observation is in the bioms displayed, need to talk to @wasade
  • Others??

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 91.949% when pulling 5dc2b40 on redbiom into 659cb94 on master.

@antgonza antgonza requested review from wasade and josenavas May 12, 2017 18:02
@antgonza
Copy link
Member Author

@wasade, @josenavas wrong PR, sorry, will add you to the other one.

@antgonza
Copy link
Member Author

Closing in favor of: #2282

@antgonza antgonza closed this Sep 13, 2017
@josenavas josenavas deleted the redbiom branch September 15, 2017 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants