Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding checksum into the DB #74

Merged
merged 5 commits into from
Jun 10, 2014
Merged

Conversation

josenavas
Copy link
Contributor

This adds checksum support to the DB. Specifically:

  • New table checksum_algorithm with two columns: checksum_algorithm_id and name to store the algorithms used for the checksum generation.
  • Two new columns on table filepath: checksum (stores the actual checksum) and checksum_algorithm_id (foreign key to checksum_algorithm table).

The files initialize.sql and populate_test_db.sql have been updated to reflect this changes.

This should be fast to review. @squirrelo, since you've been working a lot with dbschema, it would be great if you can take a look and make sure that I've updated everything correctly. This is blocking further development on any object that modifies the filepath table.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8449a38 on josenavas:checksum into a120cce on biocore:master.

@squirrelo
Copy link
Contributor

👍

);

CREATE INDEX idx_filepath ON qiita.filepath ( filepath_type_id );

CREATE INDEX idx_filepath_0 ON qiita.filepath ( checksum_algorithm_id );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why index here? It likely won't be any benefit as the data are not unique

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or even near unique

@josenavas
Copy link
Contributor Author

Thanks @wasade
I fixed your comment and the tests passed, are you able to merge?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a68eb5e on josenavas:checksum into a120cce on biocore:master.

wasade added a commit that referenced this pull request Jun 10, 2014
Adding checksum into the DB
@wasade wasade merged commit d1d64e1 into qiita-spots:master Jun 10, 2014
@josenavas josenavas deleted the checksum branch June 11, 2014 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants