-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding checksum into the DB #74
Conversation
👍 |
); | ||
|
||
CREATE INDEX idx_filepath ON qiita.filepath ( filepath_type_id ); | ||
|
||
CREATE INDEX idx_filepath_0 ON qiita.filepath ( checksum_algorithm_id ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why index here? It likely won't be any benefit as the data are not unique
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or even near unique
Thanks @wasade |
This adds checksum support to the DB. Specifically:
checksum_algorithm
with two columns:checksum_algorithm_id
andname
to store the algorithms used for the checksum generation.filepath
:checksum
(stores the actual checksum) andchecksum_algorithm_id
(foreign key tochecksum_algorithm
table).The files
initialize.sql
andpopulate_test_db.sql
have been updated to reflect this changes.This should be fast to review. @squirrelo, since you've been working a lot with dbschema, it would be great if you can take a look and make sure that I've updated everything correctly. This is blocking further development on any object that modifies the
filepath
table.