Data objects #75
Merged
Data objects #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…submitted_to_insdc methods, as well as adding their tests
|
This is ready for review/merge!!! Any takers? |
| "INSERT INTO qiita.{0} (filepath, filepath_type_id, checksum, " | ||
| "checksum_algorithm_id) VALUES {1} " | ||
| "RETURNING filepath_id".format(self._filepath_table, | ||
| ', '.join(values))) |
There was a problem hiding this comment.
would be safer here to just use %s instead of direct values and add the values in using psycopg2.
There was a problem hiding this comment.
Ah, I see, weird execute many for fetchall. Still would be good to use one of the escape functions to clean the values before entering them into the db.
|
Just a couple comments. Let me know when I can do another review. |
|
@squirrelo Ready for a new review. |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54
Fixes #48
Fixes #47
Fixes #46
Introduces the raw/preprocessed/processed data objects. As discussed offline with @adamrp, since the database is aware of filepaths