Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdup tmp file name #74

Closed
rernst opened this issue May 27, 2014 · 3 comments
Closed

markdup tmp file name #74

rernst opened this issue May 27, 2014 · 3 comments

Comments

@rernst
Copy link
Contributor

rernst commented May 27, 2014

Running markdup in paralel (using the same tmp folder for all processes) will result in a crash: sambamba-markdup: Failed to remove file /tmp/sorted.0.bam: No such file or directory.

Can probably be solved by using an unique or random filename?

@pjotrp
Copy link
Member

pjotrp commented May 27, 2014

:) I am working on similar things with bio-vcf. I suggest we use $TEMDIR/sambamba-pid5466/sorted.0.bam, instead, where pid is the mother process id. It would be even better to use named random names, but a collision is unlikely using the pid dir and it is much easier to clean up after.

@lomereiter
Copy link
Contributor

Good point, it should be fixed now.
@pjotrp thanks for suggestion, I decided to add both PID and random suffix to subdirectory name.

@rernst
Copy link
Contributor Author

rernst commented May 28, 2014

Awesome, thanks for the very quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants