Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Remove LVEF < 40 from the Website #28

Open
NameAtirut opened this issue Jul 28, 2023 · 5 comments
Open

[Frontend] Remove LVEF < 40 from the Website #28

NameAtirut opened this issue Jul 28, 2023 · 5 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@NameAtirut
Copy link
Collaborator

NameAtirut commented Jul 28, 2023

We have now removed the lvef40 model from the API. As a result, a random value is returned for this field on the website (as shown in the attached image).

My suspect is that lines 43 and 44 of this file are the cause

return ["scar", "lvef40", "lvef50"].map((modelName) => {
const probability = Math.floor(Math.random() * 100);

I'm not entirely sure if simply removing lvef40 from the list will solve this or affect anything else.
Could you please investigate this for me?

image

@NameAtirut NameAtirut added the bug Something isn't working label Jul 28, 2023
@NameAtirut NameAtirut changed the title [Frontend] Remove "lvef40" from the Website [Frontend] Remove LVEF < 40 from the Website Jul 28, 2023
@NameAtirut NameAtirut added the enhancement New feature or request label Jul 28, 2023
@titipata
Copy link
Contributor

@bluenex can you take a quick look on this issue?

@bluenex
Copy link
Collaborator

bluenex commented Jul 29, 2023

Sure, will check by today.

@bluenex
Copy link
Collaborator

bluenex commented Jul 29, 2023

@NameAtirut if you mean https://hatai-ai.pages.dev/ecg, that is the test site that doesn't connect to the actual backend yet, so it generates random values regardless of the model.

@titipata I don't recall we deploy this project under your domain name (*.biodatlab.com), have we deployed it somewhere?

@titipata
Copy link
Contributor

titipata commented Jul 29, 2023

@bluenex We want to run the demo locally (e.g. make an API call to port 8000). Not sure where we can adjust it to use the local API. I guess the frontend already renders the key-value that we send it right?

@bluenex
Copy link
Collaborator

bluenex commented Jul 29, 2023

@titipata correct, if the backend is up at localhost:8000 and there is no .env containing NEXT_PUBLIC_ENABLE_MIRAGE=TRUE in frontend folder, it should render correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants