-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datasets: best practices and questions #147
Comments
Hi @constantinpape It's good that you started to look into this. We have very loose definition at the moment, here are some examples from zero: https://github.com/HenriquesLab/ZeroCostDL4Mic/blob/8ba67e98a894cb271b98fa8da2ec46af46a541fe/manifest.bioimage.io.yaml#L29-L55 The source can be any URI at the moment. So you can basically upload a rdf.yaml file with source=https://cremi.org/... to zenodo. You should be able to do this the same way as you do for models, and you should be able to update it as well (we don't have dedicated UI for dataset though, so you need to edit the yaml file directly). (also see the dataset RDF discussion here) |
Thanks, that's a good starting point! I will see how upload via the website works for this. |
@oeway, I tried uploading a dataset rdf.yaml, but it fails: ds_upload-2021-07-14_15.34.20.mp4The console shows the following error:
|
Ok, I will fix that! |
@constantinpape It should been fixed now! Sorry that I forgot to implement the yaml load at all, we treated is as a zip and try to parse with jszip. Please give it a try in the preview (BTW, you can find a bug report button in the netlify preview page located in the lower left corner, if needed you can use that to record screen and fire bug report directly ;). BTW, I am thinking also to replace the jszip with uzip in the website too. |
@oeway thanks for fixing this, and in theory it works now, but it requires a license in order to upload it. Edit: I will go with CC-BY-4 for now, but this is something we should discuss. |
If we just add a link to the RDF, I would actually interpret the license as the license for the RDF file only. The license would apply to the entire dataset if the files are referred in relative path in the same zenodo deposit. How about that? We can also add a note for the license definition. |
Yes, that makes sense but it feels a bit unnecessary to add a license if we just link to some external resource. |
@oeway did you see the 2 datasets i uploaded and could you add them to the zenodo community so that they show in the website? |
@constantinpape I already accepted it a while ago, and I just checked the console log of the website, it doesn't like the cover URL, because we assume the cover image are uploaded to zenodo. I made it like that because an arbitrary cover image may disappear, or simple because the server doesn't have CORS enabled. So it would be better if you can upload include the cover image in the upload, and use a relative file path at least for now. BTW, it seems the image from the URL you provided are rather big, could you provide a smaller file to improve the loading time? e.g. a few hundreds pixels. Edit: in the future, I can also implement in the upload dialog that we will (try to) pull the external image cover image, resize it and upload to zenodo. |
Ok, I will fix it.
Ok. Btw, do we suport gifs? |
@oeway I updated the two datasets on zenodo, but still can't see them on the website. |
Yes, we do
I still see the error from the console from bioimage.io:
One issue might be that when we update the covers, we somehow miss the metadata on zenodo, these identifiers needed to be updated too: You updated from the bioimageio upload page, right? I will need to look into it why it doesn't fix the metadata. |
No, I updated directly on zenodo. Updating via page was not so easy because it wasn't listed there yet. |
That's true, ok then you only need to update the URL identifiers manually, you can copy the URL of the cover image from zenodo, then edit and change the identifier URLs for the cover image. An example URL for the cover image: https://sandbox.zenodo.org/record/880817/files/input.png EDIT: Now you can see the two: https://bioimage.io/#/?type=dataset&id=10.5072%2Fzenodo.881020 so you can also use the edit button to update from bioimage.io. |
Thanks, @oeway. It works now. |
Great! BTW, do you see the cover images for this one is broken: https://bioimage.io/#/?type=dataset&id=10.5072%2Fzenodo.881018 Could you try to update it from the upload page? |
|
@constantinpape I just checked, it only works in firefox, not chrome. Here is the error:
This is another reason for us to upload the coverimage, I think. And I guess you already did, but you just need to update the zenodo meta info, could you click edit button and go through the upload process once more? |
Ok, I will update it later. Unrelated: I pinged you in gitter, could you have a quick look and check why the isbi model is not displayed on the website rn? |
I updated the isbi dataset now and checked that it displays correctly in chrome. |
I want to add a few datasets to the website to document the training for my models better. However I am currently not quite sure what the best practices for this are. In particular:
The text was updated successfully, but these errors were encountered: