Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining issues #98

Closed
6 tasks done
constantinpape opened this issue Sep 9, 2021 · 5 comments
Closed
6 tasks done

Remaining issues #98

constantinpape opened this issue Sep 9, 2021 · 5 comments

Comments

@constantinpape
Copy link
Contributor

constantinpape commented Sep 9, 2021

Here's a list of remaining issues with the functionality here I found while working on #92.
It would be good to fix some of this before making a release, maybe except for last two points, which could be a bit more complicated.

  • prediction_pipeline (and transitively also prediction functions) only support a single input/output tensor; need example model for this
  • prediction_pipeline misses output_dtype
  • prediction_pipeline does not support models with fixed output shape
  • the pre/postprocessing is not quite consistent with https://github.com/bioimage-io/spec-bioimage-io/blob/main/supported_formats_and_operations.md
  • prediction with tiling currently only works for same output shape, but supporting changes in output shape is possible (need example model)
  • issues with normalization only based on local patches, e.g. for tiling, should fix by implementing and using the per_dataset mode
@constantinpape
Copy link
Contributor Author

@FynnBe I think it would be good to work on this (at least first 4 points) before releasing this library. I can work on the pre/post-processing things next. And we can maybe discuss how to split the other things in the bioimage.io meeting.

@constantinpape
Copy link
Contributor Author

Support for multiple tensors has been implemented in #103 and #104 and the output_dtype is not relevant any more since prediction_pipeline has output_specs now.

@FynnBe do you want to tackle fixed shapes next? You can use this model for tests.

Also, do you want to work on removing the attributes that duplicate stuff from input/output spec in prediction_pipeline? I think it would be good to also simplify that part before the release.

@FynnBe
Copy link
Member

FynnBe commented Sep 14, 2021

Yes and yes 👍

@FynnBe
Copy link
Member

FynnBe commented Sep 16, 2021

Also, do you want to work on removing the attributes that duplicate stuff from input/output spec in prediction_pipeline? I think it would be good to also simplify that part before the release.

simplified in #106

we could take it a step further and remove crreate_prepdiction_pipeline and use its __init__ instead, as it's rather trivial now.

@FynnBe
Copy link
Member

FynnBe commented Sep 16, 2021

@FynnBe do you want to tackle fixed shapes next? You can use this model for tests.

fixed shapes PR: #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants