Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling of libyaml and yaml-cpp? #5

Closed
sherief opened this issue Feb 28, 2018 · 1 comment
Closed

Bundling of libyaml and yaml-cpp? #5

sherief opened this issue Feb 28, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@sherief
Copy link

sherief commented Feb 28, 2018

While I understand the bundling of googletest, I'm not sure everyone who clones this for inclusion in a project might want yaml-cpp and libyaml too. It might be better to have a separate git repo that contains rapidYAML + libyaml + yaml-cpp for performance / correctness comparisons.

Or it might not, really. I don't know that much about your code and modus operandi so feel free to disregard this if it doesn't make much sense.

@biojppm
Copy link
Owner

biojppm commented Feb 28, 2018

That's a good point. I'll setup CMake to download and build these, instead of having them as git submodules.

@biojppm biojppm closed this as completed in 3d8695e Mar 2, 2018
@biojppm biojppm added the enhancement New feature or request label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants