Owinteractions: new widget and tablemodel #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahnovsak
force-pushed
the
owinteraction-rewrite
branch
from
8622349
to
de7ee2a
Compare
noahnovsak
changed the title
noahnovsak
force-pushed
the
owinteraction-rewrite
branch
from
de7ee2a
to
a2d6fa9
Compare
markotoplak
force-pushed
the
owinteraction-rewrite
branch
from
a2d6fa9
to
c4f9c21
Compare
|
@noahnovsak, I merged #255 and rebased this one. Do you remember any reason we didn't merge it a year ago? |
|
No, I think it's ok for prototypes... It probably needs some work before merging into the main branch though. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #254 +/- ##
==========================================
+ Coverage 33.92% 41.76% +7.83%
==========================================
Files 9 12 +3
Lines 1515 1669 +154
==========================================
+ Hits 514 697 +183
+ Misses 1001 972 -29 ☔ View full report in Codecov by Sentry. |
|
Hahaha, you got used to different naming schemes! Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
InteractionScorerrelocated and fixed main thread being slowed down bynumpy.unique. OWInteractions: fix calculation #255RankTableModelandArrayTableModeladded (currently as two separate models).OWInteractionsrewritten as it's own widget, no longer extendsOWCorrelations.These changes improve the performance of
OWInteractionsand present some opportunities forOWCorrelationsandOWScatterPlotas well. Currently all three of these widgets can generate models large enough, thatQTableModeland subsequently the rest of Orange becomes unresponsive. The idea of the new models is to save the underlying data in an array and let numpy do all the heavy lifting. Additionally improvements have been made to the process of adding items into the model in batches (the current process: generate and add items to the queue one by one, take items out one by one, add them to the model one by one).Includes