New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
With or without an As Timeseries widget, the transformation to timeseries should behave the same way #85
Comments
This is the case.
This is the case.
And this is not (yet). IIRC, the widget is there exactly to make the choice of the temporal attribute convenient and explicit. |
I think it is necessary if there is more than one time variable or there is an non-explicit continuous variable with 'pseudotime'. |
Ah, I should've opened with the use case. My dataset contains a couple of different sources merged together, so the timestamps are a bit jumbled. It seems the time delta isn't detected properly if I plug Data directly into a timeseries widget, but it works fine if I run it through As Timeseries. |
Yeah, in addition, the widget sorts: orange3-timeseries/orangecontrib/timeseries/widgets/owtabletotimeseries.py Lines 114 to 116 in 49d8648
|
I see. Plugging in what I did probably isn't too meaningful anyway, more than anything else, I was just confused as to why it was acting differently. It'd be nice if it sorted without As Timeseries too. |
@irgolic Perhaps rename the issue? |
Related: NaNs should be ignored when Data is converted to Timeseries, and in As Timeseries, a warning should be thrown instead of an error upon NaNs. Ideally, a warning should be shown in any Timeseries widget if there's NaN values present in the time variable. What's the easiest way of implementing this across the add-on, without duplicating Warning code in each widget? |
Fixed via #95. |
Connecting a Data output to a Time series input is allowed, but just shows a horizontal line.
Time series widgets should infer that 'As Timeseries' was supposed to be added in between, and try to use the first datetime feature as the sequential attribute, or instance ordering if there's no datetime feature.
The text was updated successfully, but these errors were encountered: