Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for translations #6279

Merged
merged 9 commits into from Feb 6, 2023
Merged

Fixes for translations #6279

merged 9 commits into from Feb 6, 2023

Conversation

janezd
Copy link
Contributor

@janezd janezd commented Jan 5, 2023

Description of changes

Fix messages that can't be translated (mostly because of plural forms) and some other minor related corrections.

Includes
  • Code changes
  • Tests
  • Documentation

@janezd janezd force-pushed the translation-fixes-4 branch 2 times, most recently from 254f1af to 0b7ad8f Compare January 11, 2023 18:44
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #6279 (db6c7ff) into master (3d8ae07) will increase coverage by 0.00%.
The diff coverage is 95.45%.

❗ Current head db6c7ff differs from pull request most recent head afca18e. Consider uploading reports for the commit afca18e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6279   +/-   ##
=======================================
  Coverage   87.48%   87.48%           
=======================================
  Files         316      316           
  Lines       67984    67994   +10     
=======================================
+ Hits        59475    59487   +12     
+ Misses       8509     8507    -2     

@janezd janezd added the needs discussion Core developers need to discuss the issue label Jan 11, 2023
@janezd
Copy link
Contributor Author

janezd commented Jan 11, 2023

"Needs discussion": Fail on "Oldest dependencies" (orange-canvas' localization)

@janezd janezd removed the needs discussion Core developers need to discuss the issue label Jan 14, 2023
@@ -136,7 +136,7 @@ def __init__(self):
gui.checkBox(
predopts, self, "show_probability_errors",
"Show classification errors",
tooltip="Show 1 - probability assigned to the correct class",
tooltip="Show probability assigned to the correct class",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked correct to me the way it was before?
The error is the sum of all incorrect probs i.e. 1 - prob of correct.
The wording however could be improved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What did I think here?!

Thanks, I removed the change.

@janezd janezd self-assigned this Feb 3, 2023
@janezd janezd removed their assignment Feb 3, 2023
@lanzagar lanzagar merged commit 10bb2b1 into biolab:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants