[ENH] Improve scorer selection in Test and Score and predictions #6282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
scorer-registration
branch
2 times, most recently
from
6fa3485
to
46b70f4
Compare
janezd
force-pushed
the
scorer-registration
branch
from
46b70f4
to
6d5f0ac
Compare
janezd
force-pushed
the
scorer-registration
branch
from
ae1c575
to
e8551d1
Compare
janezd
force-pushed
the
scorer-registration
branch
from
e8551d1
to
8aaa708
Compare
markotoplak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ScoreTable, which is used in Test and Score, and in Predictions, has a hard coded list of scorers, which defines the (default) visibility and the order. New scores are thus invisible by default.nameattribute exists, but is not defined and defaults to class name.Description of changes
Scorers define default visibility and priority as class attributes.
Visibility settings are stored as "hints", so new scorers (e.g. from add-ons) may be visible if they that's their default.
The
nameattribute is now defined, but in settings the scorers are referred to by their class names, so settings "survive" the change of language.Add an indicator that can be clicked and opens a popup for selection of scores (fixes Test and Score - intuitive way to add new score #6131).
Although currently in
Orange.widgets.evaluate.utils, the classSelectableColumnsHeaderis general and can be moved somewhere else and used, e.g. inOWRanks.Includes