Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: When there are no valid taxons, we accept all taxons #18

Closed
dougli1sqrd opened this issue May 16, 2017 · 2 comments
Closed

Question: When there are no valid taxons, we accept all taxons #18

dougli1sqrd opened this issue May 16, 2017 · 2 comments

Comments

@dougli1sqrd
Copy link
Contributor

In _validate_taxon() if in the config there are no valid taxons, or self.config.valid_taxa is None we accept all taxons. This seems counterintuitive, since wouldn't that mean that there does not exist a taxon that is valid?

@cmungall
Copy link
Contributor

It's perhaps unfortunate that the python reserved term in None, but really we mean unset, ie client does not care. How else should we indicate this? We could do a string like * (ugh), force the user to enumerate all possibilities (not desirable) or use a scala-esque object NotSet | List which is not very pythonesque....

@cmungall
Copy link
Contributor

We'll retain the current behavior - an empty whitelist means accept all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants