Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep Mode: Deactivating EOP, EOT, and EO5T not possible #126

Closed
GeneralLuzi opened this issue Nov 28, 2021 · 11 comments
Closed

Sleep Mode: Deactivating EOP, EOT, and EO5T not possible #126

GeneralLuzi opened this issue Nov 28, 2021 · 11 comments

Comments

@GeneralLuzi
Copy link

Hey,

MQTT-Nachricht empfangen: [Topic: Cmnd/ESPuino/SleepTimer] [Command: EOT]
Sleep-Timer: Nach dem Ende des laufenden Tracks.
MQTT-Nachricht empfangen: [Topic: Cmnd/ESPuino/SleepTimer] [Command: 0]
Sleep-Timer ist bereits deaktiviert.

After EOP, EOT, and EO5T is set, it cannot be deactivated by mqtt command. The device device goes to deep sleep mode although the log says the timer is deactivated.

Thanks and best regards

GL

biologist79 added a commit that referenced this issue Nov 28, 2021
@biologist79
Copy link
Owner

Thanks for your report!
Just provided a fix - please test.

@GeneralLuzi
Copy link
Author

GeneralLuzi commented Nov 28, 2021

nope - sorry.

The deactivation is not published via mqtt.

The log also does not also indicate the fix:

MQTT-Nachricht empfangen: [Topic: Cmnd/ESPuino/SleepTimer] [Command: EOT]
Sleep-Timer: Nach dem Ende des laufenden Tracks.
ws[/ws][1] text-message[24]: ping
RSSI: -75 dBm
MQTT: Bin noch online.
MQTT-Nachricht empfangen: [Topic: Cmnd/ESPuino/SleepTimer] [Command: 0]
Sleep-Timer ist bereits deaktiviert.

@GeneralLuzi
Copy link
Author

also the device went into deep sleep mode

ESP-IDF-version (major): 3
ESP-IDF-version (minor): 3
Software-revision: 20211128-2

@biologist79
Copy link
Owner

Just reviewed the code yesterday and discovered the problem. I'm looking forward to fix it this evening.

biologist79 added a commit that referenced this issue Dec 2, 2021
@biologist79
Copy link
Owner

2nd attempt :-)
Please test.

@GeneralLuzi
Copy link
Author

GeneralLuzi commented Dec 3, 2021

Hi,

seems to work:

MQTT-Nachricht empfangen: [Topic: Cmnd/ESPuino/SleepTimer] [Command: EOP]
Sleep-Timer: Nach dem letzten Track der Playlist.
MQTT-Nachricht empfangen: [Topic: Cmnd/ESPuino/SleepTimer] [Command: 0]
Sleep-Timer wurde deaktiviert.
MQTT-Nachricht empfangen: [Topic: Cmnd/ESPuino/SleepTimer] [Command: EOT]
Sleep-Timer: Nach dem Ende des laufenden Tracks.
MQTT-Nachricht empfangen: [Topic: Cmnd/ESPuino/SleepTimer] [Command: 0]
Sleep-Timer wurde deaktiviert.
MQTT-Nachricht empfangen: [Topic: Cmnd/ESPuino/SleepTimer] [Command: EO5T]
Sleep Timer: Nach Ende des Titels oder, wenn früher, Ende der Playlist
MQTT-Nachricht empfangen: [Topic: Cmnd/ESPuino/SleepTimer] [Command: 0]
Sleep-Timer wurde deaktiviert.
MQTT-Nachricht empfangen: [Topic: Cmnd/ESPuino/SleepTimer] [Command: 1]
LEDs wurden auf Nachtmodus gedimmt.
Modifikator: Sleep-Timer per RFID aktiviert (2 Stunden).
Sleep-Timer gesetzt auf: 1 Minute(n)
MQTT-Nachricht empfangen: [Topic: Cmnd/ESPuino/SleepTimer] [Command: 0]
Sleep-Timer wurde deaktiviert.

Also the commands are correctly published via MQTT! Well done!

However, I guess there is still an inconsistent behavior:

  1. While SleepTimer 1 Min reduces the brightness of the LEDs, the other commands don't.
  2. The deactivation of the SleepTimer should brighten up the LED, shouldn't it?

Thanks for your work so far!

biologist79 added a commit that referenced this issue Dec 3, 2021
@biologist79
Copy link
Owner

Done. By doing so I also discovered there was no dimming enabled at EOP, EOT and EO5T.
Fixed this inline.

Please test.

@GeneralLuzi
Copy link
Author

GeneralLuzi commented Dec 3, 2021

Positiv first:
EOT EO5T EOP decrease the lights, disabling sleep mode increases the light. So far so good.

However, there is no MQTT publish of the new brightness level. Could you observe please?

Thanks!

biologist79 added a commit that referenced this issue Dec 3, 2021
@biologist79
Copy link
Owner

Tried it again :-)

@GeneralLuzi
Copy link
Author

Almost. :D

The following scenario does not work:

  1. Play song with Brightness 16
  2. configure EOT, EO5T or something else
  3. de- or increase Brightness
  4. deactivate sleep timer --> Issue: brightness resets to 16 and not to the value change in between.

biologist79 pushed a commit that referenced this issue Dec 28, 2022
@biologist79
Copy link
Owner

Finally fixed it after taking almost forever 😂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants