Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phosphorylation generates duplicate ODE #183

Closed
formersbach opened this issue Aug 25, 2022 · 1 comment · Fixed by #184
Closed

Phosphorylation generates duplicate ODE #183

formersbach opened this issue Aug 25, 2022 · 1 comment · Fixed by #184
Labels
bug Something isn't working text2model Text-to-model conversion

Comments

@formersbach
Copy link
Contributor

Description:

If "is phosphorylated" reaction rule is used with a unphosphorylated species that has been previously used, a second ODE is mistakenly generated.

Reproduce:

Text file containing:

TNFR phosphorylates Ikk --> pIkk   
Ikk is phosphorylated <--> pIkk
pIkk is phosphorylated <--> ppIkk

Convert to model:

from biomass import Text2Model, create_model
model = Text2Model("test.txt")
model.convert(overwrite=True)
model = create_model(test)

Proposed changes:

Add missing format string in line 1099:

elif "dydt[V.{phosphorylated_form}]" in eq:

to

elif f"dydt[V.{phosphorylated_form}]" in eq:
@formersbach formersbach added the bug Something isn't working label Aug 25, 2022
@himoto
Copy link
Contributor

himoto commented Aug 25, 2022

Hi @formersbach, thanks for your report.
I created a pull request #184 to resolve this issue.

@himoto himoto added the text2model Text-to-model conversion label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working text2model Text-to-model conversion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants