Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample names can't end in an underscore #112

Open
lweasel opened this issue Apr 5, 2024 · 1 comment
Open

Sample names can't end in an underscore #112

lweasel opened this issue Apr 5, 2024 · 1 comment
Labels

Comments

@lweasel
Copy link
Collaborator

lweasel commented Apr 5, 2024

This breaks the filtering step, where we are using "___" as a separator for block files. We could either change this separator to something more obscure, or warn when sample names end in underscore.

cc @hxin

@lweasel lweasel added the bug label Apr 5, 2024
@hxin
Copy link
Collaborator

hxin commented Apr 5, 2024

adding a warning or a sample name check at the beginning might be a quick fix? can also change '___' as I don't think there will be any backwards-compatible issue on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants