useExhaustiveDependencies: add option for automatically

[vanch3d]

Great beginning with the plugin. Looking forward to definitely switching to biome

One issue I found a little bit annoying, compared to the ESLint plugin.
In the context of a React useEffect (I haven't tried it in any other cases), the plugin easily finds any missing dependencies on the hook:

  useEffect(() => {
    if ((state) {
      setOtherState(state)    
   }
  }, [])

But the plugin offers me only one option: suppress the rule:

What is missing is at least another option to automatically update the dependency array:

Running biome check indicates in the console the vars that are missing so the information is already there.

Note

• Webstorm version 2023.3
• biome plugin version 0.0.7

[ematipico]

Hi @vanch3d , I would suggest to open a discussion in the main repo biomejs/biome, maybe here: biomejs/biome#3

We control code actions via LSP, not the plugin. If a code action is implemented in core, the plugin will automatically display it. That's the beauty of supporting LSP :)

[srosato]

@ematipico How can I determine if the code action is implemented? I went on biomejs/biome#3 and saw green checks for useExhaustiveDependencies

But when I enable the rule like this:

  "linter": {
    "enabled": true,
    "rules": {
      "recommended": false,
      "correctness": {
        "useExhaustiveDependencies": "warn"
      }
    },

and restart the LSP server, I do not get suggestions to fix dependencies from IntelliJ.

I would assume its not yet implemented in the core, but I wonder where I can validate if its implemented or not?

Thanks!

[ematipico]

You're actually correct. If the website doesn't show the emoji for the autofix, it means it doesn't have it