Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Webstorm plugin clears package.json since 1.5.0 #1541

Closed
1 task done
Arctomachine opened this issue Jan 12, 2024 · 0 comments · Fixed by #1542
Closed
1 task done

🐛 Webstorm plugin clears package.json since 1.5.0 #1541

Arctomachine opened this issue Jan 12, 2024 · 0 comments · Fixed by #1542
Assignees
Labels
A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@Arctomachine
Copy link

Environment information

CLI:
  Version:                      1.4.1     
  Color support:                true      
                                          
Platform:                                 
  CPU Architecture:             x86_64    
  OS:                           windows   
                                          
Environment:                              
  BIOME_LOG_DIR:                unset     
  NO_COLOR:                     unset     
  TERM:                         unset     
  JS_RUNTIME_VERSION:           "v20.10.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "npm/10.2.3"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

  1. Set up node project with biome 1.5.0+ and plugin enabled
  2. Trigger auto format of package.json
  3. It becomes empty

1.4.1 - works fine (even after rolling back from newer versions)
1.5.0 - bug

Plugin disabled - ignores package.json even when specified in cli command
Plugin enabled - bug

So I conclude something in plugin is incompatible with 1.5.0 onwards

Config file from project if it helps to narrow it

{
	"$schema": "https://biomejs.dev/schemas/1.4.1/schema.json",
	"organizeImports": {
		"enabled": true
	},
	"linter": {
		"enabled": true,
		"rules": {
			"recommended": true
		}
	},
	"formatter": {
		"enabled": true,
		"indentWidth": 2,
		"indentStyle": "tab",
		"lineWidth": 80,
		"lineEnding": "crlf",
		"formatWithErrors": false
	},
	"javascript": {
		"formatter": {
			"enabled": true,
			"indentWidth": 2,
			"indentStyle": "tab",
			"lineWidth": 80,
			"lineEnding": "crlf",
			"trailingComma": "all",
			"quoteStyle": "single",
			"jsxQuoteStyle": "double",
			"quoteProperties": "asNeeded",
			"semicolons": "asNeeded",
			"bracketSameLine": false,
			"bracketSpacing": true,
			"arrowParentheses": "always"
		}
	},
	"json": {
		"formatter": {
			"enabled": true,
			"indentWidth": 2,
			"indentStyle": "tab",
			"lineWidth": 80,
			"lineEnding": "crlf"
		}
	}
}

Expected result

Just format it or skip it

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico ematipico transferred this issue from biomejs/biome Jan 12, 2024
@ematipico ematipico transferred this issue from biomejs/biome-intellij Jan 12, 2024
@ematipico ematipico added A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug labels Jan 12, 2024
@ematipico ematipico self-assigned this Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLI Area: CLI S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants