Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add composes for noUnknownProperty. #3000

Closed
Tracked by #2901
denbezrukov opened this issue May 27, 2024 · 2 comments · Fixed by #3217
Closed
Tracked by #2901

add composes for noUnknownProperty. #3000

denbezrukov opened this issue May 27, 2024 · 2 comments · Fixed by #3217
Labels
A-Diagnostic Area: diagnostocis good first issue Good for newcomers L-CSS Language: CSS

Comments

@denbezrukov
Copy link
Contributor

denbezrukov commented May 27, 2024

The current implementation of noUnknownProperty raises an error for the composes property, which is a part of the CSS Modules syntax (refer to CSS Modules Documentation). We need to modify the implementation so that it does not raise an error for the composes property if the css_modules option is enabled.

.className {
  color: green;
  background: red;
}

.otherClassName {
  composes: className;
  color: yellow;
}
@denbezrukov denbezrukov added good first issue Good for newcomers L-CSS Language: CSS A-Diagnostic Area: diagnostocis labels May 27, 2024
@denbezrukov
Copy link
Contributor Author

@chansuke What do you think?
Could it be interesting for you?🙈

@chansuke
Copy link
Member

@denbezrukov
That sounds like a good suggestion and i'd like to handle this:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Diagnostic Area: diagnostocis good first issue Good for newcomers L-CSS Language: CSS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants