Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a lint rule to highlight the deprecated @value at-rule. #3001

Open
Tracked by #2901
denbezrukov opened this issue May 27, 2024 · 5 comments
Open
Tracked by #2901

Implement a lint rule to highlight the deprecated @value at-rule. #3001

denbezrukov opened this issue May 27, 2024 · 5 comments
Assignees
Labels
A-Analyzer Area: analyzer good first issue Good for newcomers L-CSS Language: CSS

Comments

@denbezrukov
Copy link
Contributor

denbezrukov commented May 27, 2024

Implement no-value-at-rule.

Many tools, such as lightningcss and swc, consider the @value at-rule deprecated in favor of CSS variables.

References:

Want to contribute? Lets you know you are interested! We will assign you to the issue to prevent several people to work on the same issue. Don't worry, we can unassign you later if you are no longer interested in the issue! Read our contributing guide and analyzer contributing guide.

@denbezrukov
Copy link
Contributor Author

Hi @togami2864 ,

Could you please help me with this? Do you have any thoughts or suggestions?

Thank you!

@denbezrukov denbezrukov added good first issue Good for newcomers L-CSS Language: CSS A-Analyzer Area: analyzer labels May 27, 2024
@togami2864
Copy link
Contributor

Should this rule only apply to files with .module.css🤔

@denbezrukov
Copy link
Contributor Author

Should this rule only apply to files with .module.css🤔

Hmm, interesting. We have a project with css modules but we don't write .module.css.
I think it’s better to analyze all .css files, but the rule must work only if the option is enabled.

@togami2864
Copy link
Contributor

I think it’s better to analyze all .css files, but the rule must work only if the option is enabled.

Makes sense. We can ignore when the option is disabled since the parser will give a warning.
https://biomejs.dev/playground/?lineWidth=120&files.main.css=QAB2AGEAbAB1AGUAIABiAGwAdQBlADoAIAAjADAAYwA3ADcAZgA4ADsA

@rishabh3112
Copy link
Contributor

@denbezrukov interested in contributing this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Analyzer Area: analyzer good first issue Good for newcomers L-CSS Language: CSS
Projects
None yet
Development

No branches or pull requests

3 participants