Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaCyc reaction does not resolve #1009

Open
hrshdhgd opened this issue Dec 6, 2023 · 2 comments
Open

MetaCyc reaction does not resolve #1009

hrshdhgd opened this issue Dec 6, 2023 · 2 comments

Comments

@hrshdhgd
Copy link
Contributor

hrshdhgd commented Dec 6, 2023

Continued from #1008

In Metacyc, the reaction seen here would have a bioregistry based CURIE as metacyc.reaction:1.1.1.198 (1.1.1.198 is actually the EC number, so I don't know if this is correct). When I lookup bioregistry.io/metacyc.reaction:1.1.1.198, it takes me to https://metacyc.org/META/NEW-IMAGE?type=REACTION&object=1.1.1.198 which does not seem correct.

@cmungall
Copy link
Contributor

cmungall commented Dec 6, 2023

The immediate issue here is that 1.1.1.198 is not the MetaCyc local ID, the actual local ID is +-BORNEOL-DEHYDROGENASE-RXN

You can see this under "Biocyc ID" here:

https://metacyc.org/META/NEW-IMAGE?type=REACTION&object=%2b-BORNEOL-DEHYDROGENASE-RXN

Now, the challenge here is that IMO this is a poor local ID that doesn't compose well with web standards (in their defence, MetaCyc/BioCyc predated the semantic web). The local ID has "+" symbols in it, which seems not a great choice for IDs in general.

If we try and construct a bioregistry resolution URL for this:
https://bioregistry.io/reference/metacyc.reaction:+-BORNEOL-DEHYDROGENASE-RXN

it makes
https://metacyc.org/META/NEW-IMAGE?type=REACTION&object=+-BORNEOL-DEHYDROGENASE-RXN

which gives us a 404 The object -BORNEOL-DEHYDROGENASE-RXN was not found in KB METABASE - you can see the + is getting lost here.

Now, we can pretend that the CURIE here is metacyc.reaction:%2b-BORNEOL-DEHYDROGENASE-RXN

But if we try and resolve
https://bioregistry.io/reference/metacyc.reaction:%2b-BORNEOL-DEHYDROGENASE-RXN

This just gets turned into:
https://bioregistry.io/reference/metacyc.reaction:+-BORNEOL-DEHYDROGENASE-RXN

This is quite thorny and I suggest we invite BioCyc people onto this conversation to help come up with a solution

@cthoyt
Copy link
Member

cthoyt commented Dec 7, 2023

cc @pkarp111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants